Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow selectors in noarch_platforms recipes #1682

Merged
merged 3 commits into from
Oct 29, 2022
Merged

allow selectors in noarch_platforms recipes #1682

merged 3 commits into from
Oct 29, 2022

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Oct 25, 2022 •
edited
Loading

Checklist

  • Added a news entry

@isuruf isuruf requested a review from a team October 26, 2022 02:12
jaimergp
jaimergp reviewed Oct 26, 2022
View reviewed changes
conda_smithy/lint_recipe.py
)
)
if forge_yaml_filename:
with open(forge_yaml_filename[0], "r") as fh:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we check for noarch_platforms in all existing conda-forge.ymls, not just the first one we found? Or is it guaranteed that only one exists?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's only one used.

@isuruf isuruf mentioned this pull request Oct 26, 2022
Merged
5 tasks
@isuruf isuruf requested a review from jaimergp October 26, 2022 16:06
@isuruf
Copy link
Member Author

isuruf commented Oct 29, 2022

@jaimergp, ping

@isuruf isuruf merged commit 91e394b into conda-forge:main Oct 29, 2022
@isuruf isuruf deleted the noarch_platforms branch October 29, 2022 20:30
@h-vetinari h-vetinari mentioned this pull request Oct 31, 2022
Open
@jaimergp jaimergp mentioned this pull request Nov 1, 2022
Merged
5 tasks
@BastianZim
Copy link
Member

BastianZim commented Nov 7, 2022 •
edited
Loading

I’m still getting the lintong error: conda-forge/spyder-kernels-feedstock#86 (comment)

Did I do something wrong?

Edit: Is this the reason: #1682 (comment)

BastianZim
BastianZim reviewed Nov 7, 2022
View reviewed changes
conda_smithy/lint_recipe.py
@@ -913,8 +941,10 @@ def is_selector_line(line):
return False
m = sel_pat.match(line)
if m:
m.group(3)
return True
if allow_platforms and m.group(3) in ["win", "linux", "osx", "unix"]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this also be the opposite? Meaning not win etc.?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check #1735

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This was referenced May 17, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BastianZim BastianZim BastianZim left review comments

@jaimergp jaimergp jaimergp approved these changes

@beckermr beckermr beckermr approved these changes

@xhochy xhochy xhochy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@isuruf @BastianZim @xhochy @jaimergp @beckermr